Skip to content

Update crashpad. #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2021
Merged

Update crashpad. #3130

merged 2 commits into from
Nov 12, 2021

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Nov 11, 2021

Pulled in crashpad, and fixed the build. Tested on api 26 and api 30.

@google-cla google-cla bot added the cla: yes Override cla label Nov 11, 2021
@mrober mrober requested a review from kmandrika November 11, 2021 18:06
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (fe64756) and head commit (fca028f5).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (fca028f5) is created by Prow via merging commits: fe64756 38caa60.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-crashlytics-ndk

    Type Base (fe64756) Head (fca028f5) Diff
    aar 1.68 MB 1.67 MB -13.5 kB (-0.8%)
    apk (aggressive / arm64-v8a) 1.34 MB 1.32 MB -16.4 kB (-1.2%)
    apk (aggressive / armeabi-v7a) 839 kB 831 kB -8.19 kB (-1.0%)
    apk (aggressive / x86) 1.38 MB 1.36 MB -12.3 kB (-0.9%)
    apk (aggressive / x86_64) 1.44 MB 1.43 MB -12.3 kB (-0.9%)
    apk (release / arm64-v8a) 1.98 MB 1.96 MB -16.4 kB (-0.8%)
    apk (release / armeabi-v7a) 1.47 MB 1.47 MB -8.19 kB (-0.6%)
    apk (release / x86) 2.01 MB 2.00 MB -12.3 kB (-0.6%)
    apk (release / x86_64) 2.08 MB 2.07 MB -12.3 kB (-0.6%)

Test Logs

Notes

Head commit (fca028f5) is created by Prow via merging commits: fe64756 38caa60.

@mrober mrober requested a review from mrichards November 12, 2021 17:32
mrichards
mrichards approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, though we should do some extensive manual testing before the next release.

@mrober mrober merged commit 9fc1d69 into master Nov 12, 2021
@mrober mrober deleted the ndk-crashpad branch November 12, 2021 18:54
@firebase firebase locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmandrika kmandrika kmandrika approved these changes

@mrichards mrichards mrichards approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @kmandrika @mrichards