Update document index entries #3132
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (938d3e4c) is created by Prow via merging commits: e3f12a5 001ef5e. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (938d3e4c) is created by Prow via merging commits: e3f12a5 001ef5e. |
schmidt-sebastian
force-pushed
the
mrschmidt/updateindices
branch
from
89d1109 to
055a51a
Compare
| } | ||
| /** Represents an index entry saved by the SDK in its local storage. */ | ||
| @AutoValue | ||
| public abstract class IndexEntry implements Comparable<IndexEntry> { |
There was a problem hiding this comment.
Made this an AutoValue so that we have hash/equals. I am also planning to keep this class so I removed the TODO that says it is a placeholder.
| @@ -52,9 +52,6 @@ | |||
| */ | |||
| List<ResourcePath> getCollectionParents(String collectionId); | |||
|
|
|||
| /** Updates the index entries for the given document. */ | |||
| void handleDocumentChange(@Nullable Document oldDocument, @Nullable Document newDocument); | |||
There was a problem hiding this comment.
All updates will be handled by updateIndexEntries.
|
|
||
| public static int compareByteArrays(byte[] left, byte[] right) { | ||
| int size = Math.min(left.length, right.length); | ||
| for (int i = 0; i < size; i++) { |
There was a problem hiding this comment.
This code is identical with the implementation right below.
|
/test device-check-changed |
|
/test check-changed |
| document.getKey(), | ||
| uid, | ||
| directionalValue, | ||
| /* arrayValue= */ new byte[] {})); |
There was a problem hiding this comment.
Using empty byte array instead of null makes queries easier.
...base-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java
Show resolved
Hide resolved
...base-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java
Show resolved
Hide resolved
|
/test check-changed |
No description provided.