Skip to content

Restructure docs for KTX #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Restructure docs for KTX #314

merged 4 commits into from
Mar 28, 2019

Conversation

samtstern
Copy link
Contributor

Main changes:

  • Move the main page for this repo on firebaseopensource.com to be docs/README.md so we can present a less-technical overview.
  • Add a new folder docs with subpages
  • Add links to the main and KTX reference docs

cc @ashwinraghav @vkryachko we will need to actually fill out the content on KTX

@googlebot googlebot added the cla: yes Override cla label Mar 26, 2019
@earnestsaunders
Copy link

cc-ing me

Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM(modulo actual ktx content)

Is there a way for us to see what it would render like? Curious how tabs work

@samtstern
Copy link
Contributor Author

@vkryachko yeah I need to add better staging capabilities, but here's a repo that has tabs:
https://firebaseopensource.com/projects/firebase/emberfire/

You can see them in the blue bar, they're the series of external links.

@samtstern
Copy link
Contributor Author

@vkryachko @earnestsaunders can you take a look at the content I put in? It's super basic at the moment.

Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samtstern samtstern merged commit 020d6f4 into master Mar 28, 2019
@samtstern
Copy link
Contributor Author

Local preview looking good!
image

@google-oss-bot
Copy link
Contributor

@samtstern: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
connected-check-changed 0a4bf72 link /test connected-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@samtstern samtstern deleted the ss-opensource-site branch April 5, 2019 15:31
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants