Add API to filter overlays by batch ID #3145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (e08cfd0a) is created by Prow via merging commits: 710046b 309c0f4. |
thebrianchen
approved these changes
Nov 18, 2021
| /** Returns all saved overlay for the given collection. */ | ||
| Map<DocumentKey, Mutation> getOverlays(ResourcePath collection); | ||
| /** | ||
| * Returns all saved overlay for the given collection. |
| @@ -82,7 +82,7 @@ public void removeOverlaysForBatchId(int batchId) { | |||
| } | |||
|
|
|||
| @Override | |||
| public Map<DocumentKey, Mutation> getOverlays(ResourcePath collection) { | |||
| public Map<DocumentKey, Mutation> getOverlays(ResourcePath collection, int sinceBathId) { | |||
There was a problem hiding this comment.
Ugh. Fixed.
| result.put(entry.getKey(), entry.getValue().second); | ||
|
|
||
| Pair<Integer, Mutation> batchIdToOverlay = entry.getValue(); | ||
| if (batchIdToOverlay.first >= sinceBatchId) { |
There was a problem hiding this comment.
Just double checking that we want inclusive bound. We currently don't do that for sinceReadTime link
There was a problem hiding this comment.
I guess we don't since we will already be at the largest batch Id.
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (e08cfd0a) is created by Prow via merging commits: 710046b 309c0f4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.