Make FieldIndex an AutoValue #3147
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (57e62061) is created by Prow via merging commits: 0e5ccca a75fb63. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (57e62061) is created by Prow via merging commits: 0e5ccca a75fb63. |
| } | ||
| parsedIndices.add(fieldIndex); |
There was a problem hiding this comment.
I think this is an actual bug. I changed the test to catch this.
There was a problem hiding this comment.
I don't fully follow. What was the original bug?
There was a problem hiding this comment.
It adds an the same index multiple times if it has more than one field.
| @@ -29,132 +28,64 @@ | |||
| @Config(manifest = Config.NONE) | |||
| public class FieldIndexTest { | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
These tests are not needed anymore since equals() is generated.
| } | ||
| parsedIndices.add(fieldIndex); |
There was a problem hiding this comment.
I don't fully follow. What was the original bug?
| List<FieldIndex.Segment> segments = | ||
| serializer.decodeFieldIndexSegments(Index.parseFrom(row.getBlob(2))); | ||
| SnapshotVersion updateTime = | ||
| new SnapshotVersion(new Timestamp(row.getLong(3), row.getInt(4))); |
There was a problem hiding this comment.
Seconds are stored in SQLite as INTEGER, does it auto-convert to long?
There was a problem hiding this comment.
INTEGER means non-floating number of any storage size for SQLite: https://www.sqlite.org/datatype3.html
This changes FIeldIndex to be an AutoValue with the goal to make it easier to extend and add new properties.