Skip to content

[DO NOT SUBMIT] Overlay performance tests #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Nov 23, 2021

All data are from the average of three runs.

As expected, with overlay the query performance stays constant as the number of local mutations grows; while without overlay, the query performance grows linearly as the number of local mutations grows.

Without Overlay

Write 10,000 mutations, each document has 1 mutation: 11614ms
Run 100 queries: 3932ms

Write 40,000 mutations, each document has 4 mutations: 57618ms
Run 100 queries: 7987ms

Write 70,000 mutations, each document has 7 mutations: 108599ms
Run 100 queries: 11798ms

Write 100,000 mutations, each document has 10 mutations: 168217ms
Run 100 queries: 15406ms

With Overlay

Write 10,000 mutations, each document has 1 mutation: 15327ms
Run 100 queries: 4493ms

Write 40,000 mutations, each document has 4 mutations: 67575ms
Run 100 queries: 4278ms

Write 70,000 mutations, each document has 7 mutations: 123661ms
Run 100 queries: 4767ms

Write 100,000 mutations, each document has 10 mutations: 185487ms
Run 100 queries: 4699ms

@google-cla google-cla bot added the cla: yes Override cla label Nov 23, 2021
@wu-hui
Copy link
Contributor Author

wu-hui commented Nov 23, 2021

Note: there is also an increase about 30% on mutation write time, because the SDK now writes more data with local mutations. Things might improve when we remove base mutations, we should re-run this test when they are removed.

@wu-hui
Copy link
Contributor Author

wu-hui commented Nov 23, 2021

RAW log attached:

performance.txt

@wu-hui wu-hui closed this Nov 23, 2021
@wu-hui wu-hui mentioned this pull request Nov 23, 2021
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.getAsyncQueue() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (a8f8dd9) and head commit (8ec0b227).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8ec0b227) is created by Prow via merging commits: a8f8dd9 071ecbf.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (a8f8dd9) Head (8ec0b227) Diff
    aar 1.22 MB 1.22 MB +49 B (+0.0%)
    apk (release) 3.32 MB 3.32 MB -28 B (-0.0%)

Test Logs

Notes

Head commit (8ec0b227) is created by Prow via merging commits: a8f8dd9 071ecbf.

@google-oss-bot
Copy link
Contributor

@wu-hui: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 071ecbf link /test api-information
check-changed 071ecbf link /test check-changed
device-check-changed 071ecbf link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants