Fad moving update app functionality to firebaseAppDistribution class #3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (7cf188ed) is created by Prow via merging commits: d0048fd c7f9cad. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (7cf188ed) is created by Prow via merging commits: d0048fd c7f9cad. |
rachaprince
suggested changes
Nov 24, 2021
...ribution/src/test/java/com/google/firebase/app/distribution/FirebaseAppDistributionTest.java
Outdated
Show resolved
Hide resolved
...ribution/src/test/java/com/google/firebase/app/distribution/FirebaseAppDistributionTest.java
Outdated
Show resolved
Hide resolved
...ribution/src/test/java/com/google/firebase/app/distribution/FirebaseAppDistributionTest.java
Outdated
Show resolved
Hide resolved
...app-distribution/src/test/java/com/google/firebase/app/distribution/UpdateAppClientTest.java
Show resolved
Hide resolved
rachaprince
approved these changes
Nov 29, 2021
...ribution/src/test/java/com/google/firebase/app/distribution/FirebaseAppDistributionTest.java
Outdated
Show resolved
Hide resolved
manny-jimenez
commented
Nov 30, 2021
...distribution/src/main/java/com/google/firebase/app/distribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
pranavrajgopal
approved these changes
Nov 30, 2021
manny-jimenez
force-pushed
the
fad_move_updateApp
branch
from
08e1569 to
c7f9cad
Compare
schmidt-sebastian
pushed a commit
that referenced
this pull request
Dec 1, 2021
#3167) * Fad removing update app functionality to firebaseAppDistribution class * lint fixes * Moving updateApp tests to firebase app distribution * Responding to feedback and moving tests to their respective clients * Fixing rebase and changing updateApp to private Co-authored-by: Manny Jimenez <[email protected]>
manny-jimenez
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.