Random changes for Indexing #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes I made during debugging.
| public static class Results { | ||
| private final boolean hasRun; | ||
|
|
||
| private final int documentsProcessed; |
There was a problem hiding this comment.
FYI I don't think we will ever differentiate between documentsWritten and documentsDeleted as they are handled interchangeably by IndexManager.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (ad4b1e7b) is created by Prow via merging commits: 486abaf 486be8d. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (ad4b1e7b) is created by Prow via merging commits: 486abaf 486be8d. |
thebrianchen
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes I made during debugging.