Skip to content

Synchronize old and new heartbeats #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 29, 2021
Merged

Synchronize old and new heartbeats #3177

merged 8 commits into from
Nov 29, 2021

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Nov 25, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 25, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-common

    SDK overall coverage changed from 56.37% (feb69dd) to 64.96% (81f86940) by +8.59%.

    Filename Base (feb69dd) Head (81f86940) Diff
    DefaultHeartBeatController.java 42.86% 93.65% +50.79%
    FirebaseCommonRegistrar.java 95.83% 95.74% -0.09%
    HeartBeatInfo.java 0.00% 100.00% +100.00%
    HeartBeatInfoStorage.java 87.80% 90.57% +2.76%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (81f869403) is created by Prow via merging commits: feb69dd 9e3d46b.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (feb69dd) Head (81f86940) Diff
    aar 49.0 kB 47.3 kB -1.75 kB (-3.6%)
    apk (aggressive) 80.7 kB 80.3 kB -400 B (-0.5%)
    apk (release) 637 kB 637 kB -368 B (-0.1%)

Test Logs

Notes

Head commit (81f869403) is created by Prow via merging commits: feb69dd 9e3d46b.

@VinayGuthal
Copy link
Contributor Author

/test check-changed

1 similar comment
@VinayGuthal
Copy link
Contributor Author

/test check-changed

vkryachko
vkryachko reviewed Nov 25, 2021
View reviewed changes
@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 9e3d46b link /test smoke-tests
device-check-changed 9e3d46b link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VinayGuthal VinayGuthal merged commit 2dd41ce into platform_logging_main_branch Nov 29, 2021
@VinayGuthal VinayGuthal deleted the platform_logging_synchronization branch November 29, 2021 17:45
@firebase firebase locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinayGuthal @google-oss-bot @vkryachko