Use collection_path + document_id in overlay table #3178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (cff15e99) is created by Prow via merging commits: a5f2f99 986c6b2. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (cff15e99) is created by Prow via merging commits: a5f2f99 986c6b2. |
schmidt-sebastian
approved these changes
Nov 29, 2021
| return db.query("SELECT overlay_mutation FROM document_overlays WHERE uid = ? AND path = ?") | ||
| .binding(uid, path) | ||
| String collectionPath = EncodedPath.encode(key.getPath().popLast()); | ||
| String documentId = key.getPath().getLastSegment(); |
There was a problem hiding this comment.
FYI I just added helpers in #3173
You can probably just copy the changed from DocumentKey and make them part of this PR as well.
There was a problem hiding this comment.
I plan to do that in the next PR, the one to release overlay.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.