remove the ReleaseIdentifierStorage, rely on apk hash #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaprince
requested review from
pranavrajgopal and
manny-jimenez
and removed request for
pranavrajgopal
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (f0cc9f48) is created by Prow via merging commits: c012ba8 6321308. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (f0cc9f48) is created by Prow via merging commits: c012ba8 6321308. |
manny-jimenez
approved these changes
Nov 30, 2021
added 2 commits
December 1, 2021 11:46
…sh-to-release-id-datastore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need the ReleaseIdentifer storage, because the apk hash is calculated on the backend. This PR cleans up the SDK code base.
I confirmed that there are no apks without a zip hash in our backend.