Skip to content

remove heartbeat unused apis #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2021
Merged

remove heartbeat unused apis #3198

merged 4 commits into from
Dec 7, 2021

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Dec 1, 2021
@VinayGuthal VinayGuthal requested a review from vkryachko December 1, 2021 18:34
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021

Coverage Report

Affected SDKs

  • firebase-common

    SDK overall coverage changed from ? (ba0e6c4) to 55.86% (1c24a920) by ?.

    Click to show coverage changes in 29 files.
    Filename Base (ba0e6c4) Head (1c24a920) Diff
    AutoValue_HeartBeatResult.java ? 0.00% ?
    AutoValue_LibraryVersion.java ? 58.33% ?
    AutoValue_SdkHeartBeatResult.java ? 54.55% ?
    ComponentDiscoveryService.java ? 0.00% ?
    DataCollectionConfigStorage.java ? 88.89% ?
    DataCollectionDefaultChange.java ? 100.00% ?
    DefaultHeartBeatInfo.java ? 22.22% ?
    DefaultUserAgentPublisher.java ? 95.45% ?
    EmulatedServiceSettings.java ? 0.00% ?
    FirebaseApp.java ? 52.68% ?
    FirebaseAppLifecycleListener.java ? 0.00% ?
    FirebaseCommonRegistrar.java ? 95.74% ?
    FirebaseError.java ? 0.00% ?
    FirebaseInitProvider.java ? 58.82% ?
    FirebaseNetworkException.java ? 0.00% ?
    FirebaseOptions.java ? 31.94% ?
    FirebaseTooManyRequestsException.java ? 0.00% ?
    GlobalLibraryVersionRegistrar.java ? 75.00% ?
    HeartBeatConsumer.java ? 0.00% ?
    HeartBeatConsumerComponent.java ? 0.00% ?
    HeartBeatInfo.java ? 0.00% ?
    HeartBeatInfoStorage.java ? 80.65% ?
    HeartBeatResult.java ? 0.00% ?
    KotlinDetector.java ? 66.67% ?
    LibraryVersion.java ? 100.00% ?
    LibraryVersionComponent.java ? 100.00% ?
    PublicApi.java ? 0.00% ?
    SdkHeartBeatResult.java ? 100.00% ?
    UserAgentPublisher.java ? 0.00% ?
  • firebase-messaging

    SDK overall coverage changed from ? (ba0e6c4) to 85.45% (1c24a920) by ?.

    Click to show coverage changes in 40 files.
    Filename Base (ba0e6c4) Head (1c24a920) Diff
    AutoProtoEncoderDoNotUseEncoder.java ? 98.17% ?
    CommonNotificationBuilder.java ? 91.22% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 76.60% ?
    ExecutorFactory.java ? 0.00% ?
    FcmBroadcastProcessor.java ? 83.33% ?
    FcmExecutors.java ? 60.00% ?
    FcmLifecycleCallbacks.java ? 100.00% ?
    FirebaseInstanceIdReceiver.java ? 72.73% ?
    FirebaseMessaging.java ? 75.11% ?
    FirebaseMessagingRegistrar.java ? 100.00% ?
    FirebaseMessagingService.java ? 94.03% ?
    GmsRpc.java ? 83.15% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 80.99% ?
    MessagingClientEvent.java ? 93.58% ?
    MessagingClientEventExtension.java ? 76.47% ?
    Metadata.java ? 57.14% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    ProtoEncoderDoNotUse.java ? 50.00% ?
    ProxyNotificationInitializer.java ? 93.75% ?
    ProxyNotificationPreferences.java ? 88.89% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    RequestDeduplicator.java ? 90.00% ?
    SendException.java ? 100.00% ?
    ServiceStarter.java ? 87.50% ?
    SharedPreferencesQueue.java ? 98.65% ?
    Store.java ? 74.19% ?
    SyncTask.java ? 70.83% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.47% ?
    TopicsSyncTask.java ? 53.33% ?
    WakeLockHolder.java ? 95.00% ?
    WithinAppServiceBinder.java ? 90.91% ?
    WithinAppServiceConnection.java ? 83.75% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (1c24a920) is created by Prow via merging commits: ba0e6c4 0aa9eaf.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (97fe950) Head (ffd3974b) Diff
    aar 45.5 kB 44.3 kB -1.27 kB (-2.8%)
    apk (release) 635 kB 635 kB -592 B (-0.1%)
  • firebase-datatransport

    Type Base (97fe950) Head (ffd3974b) Diff
    apk (release) 721 kB 721 kB -696 B (-0.1%)
  • firebase-installations

    Type Base (97fe950) Head (ffd3974b) Diff
    apk (release) 658 kB 657 kB -408 B (-0.1%)
  • firebase-messaging

    Type Base (97fe950) Head (ffd3974b) Diff
    apk (aggressive) 545 kB 545 kB -4 B (-0.0%)
    apk (release) 2.46 MB 2.46 MB -720 B (-0.0%)

Test Logs

Notes

Head commit (ffd3974b) is created by Prow via merging commits: 97fe950 44292ad.

Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

@VinayGuthal
Copy link
Contributor Author

/test check-changed

@VinayGuthal VinayGuthal merged commit 10cacef into master Dec 7, 2021
@VinayGuthal VinayGuthal deleted the remove_heartbeat branch December 7, 2021 19:03
@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 44292ad link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants