Don't leak orphaned docs when deleting #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Sep 20, 2018
| } | ||
| docs = updated; | ||
| return count; | ||
| ImmutableSortedMap<DocumentKey, MaybeDocument> getDocuments() { |
There was a problem hiding this comment.
Nit: Rename to getAllDocuments() to match getAllDocumentsMatchingQuery().
Feel free to disagree :)
There was a problem hiding this comment.
The other one should change to getDocumentsMatchingQuery().
There was a problem hiding this comment.
That's fine by me. Can you make this change (if you want, in a follow up?). getDocumentsMatchingQuery() is already the name we use on Web.
|
/retest |
|
/test smoke-tests-experimental |
|
/test connected-check |
|
/test connected-check |
/test smoke-tests-experimental |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we weren't deleting our tracking of orphaned documents when we deleted the doc itself. I moved the deletion into the reference delegate, which is probably a better home anyways, and delete from the orphaned doc map at the same time so we no longer leak.
Caught while porting to web.