Skip to content

Set DevelopmentPlatform info for Flutter apps #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

Set DevelopmentPlatform info for Flutter apps #3206

merged 1 commit into from
Dec 7, 2021

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Dec 6, 2021

Set DevelopmentPlatform info for Flutter apps

Also made DevelopmentPlatform delay the initialization when possible to avoid an additional file operation during start up.

@mrober mrober requested a review from mrichards December 6, 2021 14:12
@google-cla google-cla bot added the cla: yes Override cla label Dec 6, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-crashlytics

    SDK overall coverage changed from 9.81% (9466242) to 9.76% (faa268a3) by -0.04%.

    Filename Base (9466242) Head (faa268a3) Diff
    AppData.java 52.63% 56.25% +3.62%
    CrashlyticsReportDataCapture.java 4.00% 3.98% -0.02%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (faa268a3) is created by Prow via merging commits: 9466242 8216a96.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (9466242) Head (faa268a3) Diff
    aar 335 kB 337 kB +1.50 kB (+0.4%)
    apk (aggressive) 208 kB 208 kB +436 B (+0.2%)
    apk (release) 845 kB 845 kB +428 B (+0.1%)

  • firebase-crashlytics-ndk

    Type Base (9466242) Head (faa268a3) Diff
    aar 1.68 MB 1.68 MB -13 B (-0.0%)

Test Logs

Notes

Head commit (faa268a3) is created by Prow via merging commits: 9466242 8216a96.

@mrichards
Copy link
Contributor

/retest

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2021 •
edited
Loading

@mrober: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 8216a96 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mrichards
mrichards reviewed Dec 6, 2021
View reviewed changes
...tics/src/main/java/com/google/firebase/crashlytics/internal/DevelopmentPlatformProvider.java
}
}

private DevelopmentPlatform initDevelopmentPlatform() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method need to be synchronized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to not synchronize it. Because even if we have two instances, it's read-only so nothing bad will happen.

@mrichards mrichards merged commit f104b6a into master Dec 7, 2021
@mrichards mrichards deleted the devplats-flutter branch December 7, 2021 15:49
@firebase firebase locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrichards mrichards mrichards approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @mrichards