Delete index entries for deleted documents

[schmidt-sebastian]

This PR deletes the index entries when a document is removed. The entries are deleted right away, but since we don't have to do much computation this is hopefully sufficient.

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-firestore

  SDK overall coverage changed from 45.23% (072ee4c) to 45.29% (ab237e0b) by +0.06%.

  Filename	Base (072ee4c)	Head (ab237e0b)	Diff
  LocalStore.java	99.37%	99.37%	+0.00%
  MemoryIndexManager.java	70.37%	74.07%	+3.70%
  MemoryRemoteDocumentCache.java	98.08%	98.31%	+0.23%
  PatchMutation.java	100.00%	98.39%	-1.61%
  SQLiteIndexManager.java	99.06%	99.06%	+0.00%
  SQLiteLruReferenceDelegate.java	98.63%	98.67%	+0.04%
  SQLitePersistence.java	86.70%	86.84%	+0.14%
  SQLiteRemoteDocumentCache.java	96.46%	96.75%	+0.29%
  SetMutation.java	97.14%	94.29%	-2.86%

Test Logs

• Base (072ee4c7): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1468749420941021185
• Head (ab237e0b): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3209/check-coverage-changed/1468749792787042307

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ab237e0b) is created by Prow via merging commits: 072ee4c 138cddb.

[google-oss-bot]

Binary Size Report

Affected SDKs

• base

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  apk (aggressive)	?	8.39 kB	? (?)
  apk (release)	?	8.65 kB	? (?)

• firebase-annotations

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  apk (aggressive)	?	8.39 kB	? (?)
  apk (release)	?	8.83 kB	? (?)

• firebase-appcheck-interop

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  aar	?	5.17 kB	? (?)
  apk (aggressive)	?	281 kB	? (?)
  apk (release)	?	924 kB	? (?)

• firebase-common

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  aar	?	44.3 kB	? (?)
  apk (aggressive)	?	77.8 kB	? (?)
  apk (release)	?	635 kB	? (?)

• firebase-components

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  aar	?	41.4 kB	? (?)
  apk (aggressive)	?	8.68 kB	? (?)
  apk (release)	?	29.5 kB	? (?)

• firebase-database-collection

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  aar	?	33.8 kB	? (?)
  apk (aggressive)	?	268 kB	? (?)
  apk (release)	?	901 kB	? (?)

• firebase-firestore

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  aar	?	1.23 MB	? (?)
  apk (aggressive)	?	443 kB	? (?)
  apk (release)	?	3.33 MB	? (?)

• protolite-well-known-types

  Type	Base (072ee4c)	Head (ab237e0b)	Diff
  aar	?	993 kB	? (?)
  apk (aggressive)	?	134 kB	? (?)
  apk (release)	?	661 kB	? (?)

Test Logs

• Head (ab237e0b): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3209/binary-size/1468749792787042308

Notes

Head commit (ab237e0b) is created by Prow via merging commits: 072ee4c 138cddb.

[thebrianchen]

lgtm, looks good!

[google-oss-bot]

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
device-check-changed	138cddb	link	/test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.