Skip to content

[Fragment Performance] e2e test app fragments #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 15, 2021
Merged

Conversation

leotianlizhan
Copy link
Contributor

@leotianlizhan leotianlizhan commented Dec 7, 2021

b/208271664

The tests are run on Firebase Test Lab automatically. There are no validation however for screen traces.

Result

The instrumentation test will automatically scroll through the the laggy RecyclerView on a fragment, then move to the next fragment.

There was also a change to the old activity screen trace test, to try to make the instrumentation test produce screen trace which didn't do it consistently before.

How to Test

Run instrumentation tests: ./gradlew :firebase-perf:e2e-app:connectedCheck -PfireperfBuildForAutopush

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 7, 2021

Coverage Report

Affected SDKs

No changes between base commit (1db6cdf) and head commit (0b95ee1f).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0b95ee1f) is created by Prow via merging commits: 1db6cdf 4d0b0b8.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 7, 2021

Binary Size Report

Affected SDKs

No changes between base commit (1db6cdf) and head commit (0b95ee1f).

Test Logs

Notes

Head commit (0b95ee1f) is created by Prow via merging commits: 1db6cdf 4d0b0b8.

@leotianlizhan
Copy link
Contributor Author

/test api-information

Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@@ -41,6 +48,16 @@
/* initialTouchMode= */ false,
/* launchActivity= */ true);

@After
public void pressHome_toTriggerSendScreenTrace() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we triggering an event sent for every app backgrounding? I thought we were dispatching events scheduled every 30 seconds managed by Firelog service. @jeremyjiang-dev

@leotianlizhan leotianlizhan merged commit c0165e8 into master Dec 15, 2021
@leotianlizhan leotianlizhan deleted the perf-e2e-fragments branch December 15, 2021 01:47
@firebase firebase locked and limited conversation to collaborators Jan 14, 2022
@leotianlizhan leotianlizhan changed the title Perf e2e test app fragments [Fragment Performance] e2e test app fragments Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants