Skip to content

Set fis as an unloader #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 13, 2021
Merged

Set fis as an unloader #3222

merged 7 commits into from
Dec 13, 2021

Conversation

VinayGuthal
Copy link
Contributor

@VinayGuthal VinayGuthal commented Dec 8, 2021 •
edited
Loading

This pr adds the HEARTBEAT_HEADER into the http call.

@VinayGuthal VinayGuthal requested a review from vkryachko December 8, 2021 17:25
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (2dd41ce) Head (32921d71) Diff
    aar 54.6 kB 54.6 kB -36 B (-0.1%)
    apk (aggressive) 81.8 kB 81.8 kB +12 B (+0.0%)
    apk (release) 658 kB 659 kB +164 B (+0.0%)

Test Logs

Notes

Head commit (32921d71b) is created by Prow via merging commits: 2dd41ce 5d3f2b1.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-installations

    SDK overall coverage changed from 60.00% (2dd41ce) to 59.75% (32921d71) by -0.25%.

    Filename Base (2dd41ce) Head (32921d71) Diff
    FirebaseInstallationServiceClient.java 5.26% 4.80% -0.46%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (32921d71b) is created by Prow via merging commits: 2dd41ce 5d3f2b1.

@vkryachko vkryachko requested a review from yoyomyo December 8, 2021 18:25
@VinayGuthal VinayGuthal requested a review from vkryachko December 8, 2021 19:08
yoyomyo
yoyomyo reviewed Dec 9, 2021
View reviewed changes
Copy link

@yoyomyo yoyomyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR Vinay! Could you help me understand what an unloader is?

@VinayGuthal
Copy link
Contributor Author

/test device-check-changed

@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 5d3f2b1 link /test smoke-tests
device-check-changed 5d3f2b1 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VinayGuthal VinayGuthal requested a review from yoyomyo December 9, 2021 17:21
yoyomyo
yoyomyo reviewed Dec 9, 2021
View reviewed changes
...rc/main/java/com/google/firebase/installations/remote/FirebaseInstallationServiceClient.java
heartbeatInfo.get().getHeartBeatCode(FIREBASE_INSTALLATIONS_ID_HEARTBEAT_TAG);
if (heartbeat != HeartBeat.NONE) {
httpURLConnection.addRequestProperty(
USER_AGENT_HEADER, userAgentPublisher.get().getUserAgent());
Copy link

@yoyomyo yoyomyo Dec 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more userAgent? Why is that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is included in the HEARTBEAT_HEADER itself now. So we don't require two keys. Basically the HEARTBEAT_HEADER is the base64 encoding of a dictionary with userAgent as the key and the set of dates when firebase was used with that useragent string as the value. More information on this can be found at go/firebaseandroid-heartbeat

yoyomyo
yoyomyo reviewed Dec 9, 2021
View reviewed changes
Copy link

@yoyomyo yoyomyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, one question remains

@yoyomyo
Copy link

yoyomyo commented Dec 10, 2021

LGTM. Please make sure tests pass.

@VinayGuthal VinayGuthal merged commit f69f4f4 into platform_logging_main_branch Dec 13, 2021
@VinayGuthal VinayGuthal deleted the integrate_fis branch December 13, 2021 15:06
@firebase firebase locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yoyomyo yoyomyo yoyomyo left review comments

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VinayGuthal @google-oss-bot @yoyomyo @vkryachko