Skip to content

Remove Indexing flag #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2022
Merged

Remove Indexing flag #3226

merged 5 commits into from
Jan 26, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2021 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.38% (dd75b6c) to 45.36% (694b0b5) by -0.02%.

    FilenameBase (dd75b6c)Merge (694b0b5)Diff
    DeleteMutation.java90.00%95.00%+5.00%
    FirestoreClient.java30.43%30.22%-0.22%
    IndexBackfiller.java77.92%80.00%+2.08%
    LocalStore.java99.37%99.38%+0.00%
    PatchMutation.java100.00%98.39%-1.61%
    Preconditions.java56.25%43.75%-12.50%
    SetMutation.java97.14%94.29%-2.86%
    SQLiteIndexManager.java99.07%99.37%+0.30%
    SQLiteSchema.java96.68%96.63%-0.05%

Test Logs

Notes

  • Commit (694b0b5) is created by Prow via merging PR base commit (dd75b6c) and head commit (d12fd72).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/l6sjOews83.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2021 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-annotations

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.83 kB? (?)

  • firebase-appcheck-interop

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    aar?5.17 kB? (?)
    apk (aggressive)?281 kB? (?)
    apk (release)?924 kB? (?)

  • firebase-common

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    aar?44.3 kB? (?)
    apk (aggressive)?77.8 kB? (?)
    apk (release)?635 kB? (?)

  • firebase-components

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)

  • firebase-database-collection

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    aar?33.8 kB? (?)
    apk (aggressive)?268 kB? (?)
    apk (release)?901 kB? (?)

  • firebase-firestore

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    aar?1.24 MB? (?)
    apk (aggressive)?443 kB? (?)
    apk (release)?3.33 MB? (?)

  • protolite-well-known-types

    TypeBase (dd75b6c)Merge (694b0b5)Diff
    aar?993 kB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?661 kB? (?)

Test Logs

Notes

  • Commit (694b0b5) is created by Prow via merging PR base commit (dd75b6c) and head commit (d12fd72).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4HUEz6bTJ4.html

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/removeindexflag branch 2 times, most recently from 70b04ab to 937eda6 Compare December 9, 2021 17:58
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/removeindexflag branch from fca5444 to a10628d Compare January 24, 2022 20:30
@schmidt-sebastian schmidt-sebastian marked this pull request as ready for review January 24, 2022 20:33
@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Jan 26, 2022
@schmidt-sebastian
Copy link
Contributor Author

/test check-changed

@schmidt-sebastian schmidt-sebastian merged commit f25efea into master Jan 26, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removeindexflag branch January 26, 2022 17:34
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jan 31, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui