Skip to content

Handle the case where a tester has access to 0 releases #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Dec 9, 2021

Also refactored the FirebaseAppDistributionTesterApiClient a bit while I was in there, to clean up the error handling and reduce the scope of the try-catch blocks in there, which were large, catching multiple exceptions of unclear origins, etc.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 9, 2021

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 66.31% (28e1a16) to 65.66% (bf857925) by -0.65%.

    Filename Base (28e1a16) Head (bf857925) Diff
    CheckForNewReleaseClient.java 81.82% 82.42% +0.60%
    FirebaseAppDistributionTesterApiClient.java 78.75% 66.67% -12.08%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (bf857925) is created by Prow via merging commits: 28e1a16 0390ff0.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 9, 2021

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (28e1a16) Head (bf857925) Diff
    aar 118 kB 118 kB +217 B (+0.2%)
    apk (release) 1.55 MB 1.55 MB -32 B (-0.0%)

Test Logs

Notes

Head commit (bf857925) is created by Prow via merging commits: 28e1a16 0390ff0.

@lfkellogg lfkellogg force-pushed the lk/handle-app-with-no-releases branch from a681c49 to 1cccfc4 Compare December 9, 2021 18:12
@lfkellogg lfkellogg force-pushed the lk/handle-app-with-no-releases branch from 1cccfc4 to 4258052 Compare December 9, 2021 19:05
@lfkellogg
Copy link
Contributor Author

/test check-changed

Copy link

@rachaprince rachaprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only failing because of lint tests. If you run

./gradlew :firebase-app-distribution:googleJavaFormat locally, it should fix the check-changed

Also, you can run ./gradlew :firebase-app-distribution:check withErrorProne locally to see the result of check-changed.

@lfkellogg
Copy link
Contributor Author

I think this is only failing because of lint tests. If you run

./gradlew :firebase-app-distribution:googleJavaFormat locally, it should fix the check-changed

Also, you can run ./gradlew :firebase-app-distribution:check withErrorProne locally to see the result of check-changed.

Oh perfect, thanks for the tip! This also made me realize my google-java-format plugin wasn't enabled, all set now 👍

@lfkellogg lfkellogg merged commit c971713 into master Dec 10, 2021
@lfkellogg lfkellogg deleted the lk/handle-app-with-no-releases branch December 10, 2021 14:34
@firebase firebase locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants