-
Notifications
You must be signed in to change notification settings - Fork 626
Handle the case where a tester has access to 0 releases #3229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (bf857925) is created by Prow via merging commits: 28e1a16 0390ff0. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (bf857925) is created by Prow via merging commits: 28e1a16 0390ff0. |
a681c49
to
1cccfc4
Compare
1cccfc4
to
4258052
Compare
/test check-changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only failing because of lint tests. If you run
./gradlew :firebase-app-distribution:googleJavaFormat
locally, it should fix the check-changed
Also, you can run ./gradlew :firebase-app-distribution:check withErrorProne
locally to see the result of check-changed.
Oh perfect, thanks for the tip! This also made me realize my google-java-format plugin wasn't enabled, all set now 👍 |
Also refactored the FirebaseAppDistributionTesterApiClient a bit while I was in there, to clean up the error handling and reduce the scope of the try-catch blocks in there, which were large, catching multiple exceptions of unclear origins, etc.