Implement backend discovery. #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkryachko
force-pushed
the
vk.transport_backend_registration
branch
from
e9e1bf9 to
64ec5b2
Compare
The mechanism is the following: Each android libary that provides a backend needs to implement a `BackendFactory` and register it in its manifest. Runtime will discover it via manifest and create the backend via the factory, providing `CreationContext` to it.
vkryachko
force-pushed
the
vk.transport_backend_registration
branch
from
64ec5b2 to
bd7d56b
Compare
VinayGuthal
reviewed
Mar 29, 2019
...-runtime/src/main/java/com/google/android/datatransport/runtime/backends/BackendFactory.java
Show resolved
Hide resolved
|
|
||
| try { | ||
| BackendFactory provider = | ||
| (BackendFactory) |
There was a problem hiding this comment.
And do TransportBackend provider = (TransportBackend) Class.forName(backendProviderName).getInstance() ?
...nsport-backend-cct/src/main/java/com/google/android/datatransport/cct/CctBackendFactory.java
Show resolved
Hide resolved
ashwinraghav
suggested changes
Mar 29, 2019
...nsport-backend-cct/src/main/java/com/google/android/datatransport/cct/CctBackendFactory.java
Show resolved
Hide resolved
...-runtime/src/main/java/com/google/android/datatransport/runtime/backends/BackendFactory.java
Show resolved
Hide resolved
...runtime/src/main/java/com/google/android/datatransport/runtime/backends/BackendRegistry.java
Show resolved
Hide resolved
...runtime/src/main/java/com/google/android/datatransport/runtime/backends/BackendRegistry.java
Show resolved
Hide resolved
...runtime/src/main/java/com/google/android/datatransport/runtime/backends/CreationContext.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/android/datatransport/runtime/backends/CreationContextFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/datatransport/runtime/backends/TransportBackendDiscovery.java
Outdated
Show resolved
Hide resolved
vkryachko
requested review from
VinayGuthal and
ashwinraghav
and removed request for
VinayGuthal
VinayGuthal
approved these changes
Apr 1, 2019
ashwinraghav
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism is the following:
Each android libary that provides a backend needs to implement a
BackendFactoryand register it in its manifest. Runtime willdiscover it via manifest and create the backend via the factory,
providing
CreationContextto it.Design details: http://doc/17ln50RetnwUiwsVrBxQg6Ocqu8-yppaRHXJhKo3DrVo#heading=h.ny13u8okebw3