Skip to content

docs: fix ktx docs urls for firebaseopensource.com #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

thatfiredev
Copy link
Member

Previous behavior:

Clicking on the "firebase-common" or the "firebase-firestore" links from the firebase-android-sdk page would redirect the user to GitHub to be able to see these pages.

New behavior:

Now, clicking on these links shows the respective pages, but still inside firebaseopensource.com (not redirecting to GitHub).

@google-oss-bot
Copy link
Contributor

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vkryachko
Copy link
Member

/assign @samtstern

@samtstern
Copy link
Contributor

Thanks for this! It was.on my TODO list but you beat me to it.

@samtstern samtstern merged commit 69d34a4 into firebase:master Mar 29, 2019
@thatfiredev
Copy link
Member Author

thatfiredev commented Mar 30, 2019

@samtstern Now the links are redirecting to GitHub, but with a 404. Maybe we should use "docs/ktx/common.md" to match the page specified on our project.json?

@samtstern
Copy link
Contributor

@rosariopfernandes I will have to take a look at this, thanks for trying though! I'll send a PR when I figure it out, it may be a bug in the open source site's relative link parser.

@samtstern
Copy link
Contributor

This should be fixed by:
firebase/firebaseopensource.com@9fe7744

I will roll out the change.

@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants