Skip to content

Remove support for multiple sdk instances in Firebase App Distribution #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

rachaprince
Copy link

Remove support for multiple instances of the sdk. Only support the default Firebase app

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2021

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 66.77% (a336497) to 66.87% (b8cbe492) by +0.10%.

    Filename Base (a336497) Head (b8cbe492) Diff
    FirebaseAppDistribution.java 87.88% 88.96% +1.08%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (b8cbe492) is created by Prow via merging commits: a336497 e5dc742.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2021

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (a336497) Head (b8cbe492) Diff
    aar 117 kB 117 kB -151 B (-0.1%)
    apk (release) 1.55 MB 1.55 MB -160 B (-0.0%)
  • firebase-app-distribution-ktx

    Type Base (a336497) Head (b8cbe492) Diff
    aar 20.0 kB 19.8 kB -121 B (-0.6%)
    apk (release) 2.03 MB 2.03 MB -24 B (-0.0%)

Test Logs

Notes

Head commit (b8cbe492) is created by Prow via merging commits: a336497 e5dc742.

Copy link
Contributor

@manny-jimenez manny-jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems theres one failing check. Great work!

@rachaprince rachaprince merged commit 541c76e into master Dec 20, 2021
@rachaprince rachaprince deleted the fad-remove-support-for-mult-apps branch December 20, 2021 17:52
@firebase firebase locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants