Skip to content

Small indexing fixes #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2022
Merged

Small indexing fixes #3275

merged 3 commits into from
Jan 20, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 28, 2021 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.30% (514402d) to 45.31% (f9898c3) by +0.00%.

    FilenameBase (514402d)Merge (f9898c3)Diff
    FirebaseFirestore.java37.50%37.08%-0.42%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%

Test Logs

Notes

  • Commit (f9898c3) is created by Prow via merging PR base commit (514402d) and head commit (3b07a14).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qdPAZWmTZr.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 28, 2021 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (514402d)Merge (f9898c3)Diff
    aar1.24 MB1.24 MB+77 B (+0.0%)
    apk (release)3.33 MB3.33 MB-172 B (-0.0%)

Test Logs

Notes

  • Commit (f9898c3) is created by Prow via merging PR base commit (514402d) and head commit (3b07a14).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lnK5gFhJUi.html

thebrianchen
thebrianchen approved these changes Jan 4, 2022
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java Outdated
@@ -307,6 +307,10 @@ public FirebaseApp getApp() {
Task<Void> setIndexConfiguration(String json) {
ensureClientConfigured();

if (!settings.isPersistenceEnabled()) {
throw new IllegalStateException("Cannot enable indexes when persisted is disabled");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/persisted/persistence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java
JSONArray indices = jsonObject.getJSONArray("indexes");
for (int i = 0; i < indices.length(); ++i) {
JSONObject definition = indices.getJSONObject(i);
JSONArray indexes = jsonObject.getJSONArray("indexes");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename parsedIndices to parsedIndexes.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 20, 2022 •
edited
Loading

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 3b07a14 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit 39262c8 into master Jan 20, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/miscindexing branch January 20, 2022 22:31
@firebase firebase locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen