Adding IF NOT EXISTS to CREATE log_event_dropped #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected Products
Test Logs
Notes |
Coverage Report 1Affected Products
Test Logs
Notes |
|
@argzdev: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
davidmotson
approved these changes
Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #3301.
The
log_event_droppedtable was initially added onSchemaManager.javaon18.2.43.1.0EDIT: Proposed solution by mkocus is to use
DROP TABLE IF EXISTSbefore theCREATE TABLEis called.The
DROP_LOG_EVENT_DROPPED_SQLis only called duringonDowngrade, which means if somehow the migration fails half way, there is no way of continuing the migration, thus it's best to callDROP_LOG_EVENT_DROPPED_SQLwhenever creating the table to ensure this table does not exist before upgrade.