Skip to content

Add largest batch ID #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2022
Merged

Add largest batch ID #3331

merged 2 commits into from
Jan 20, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 19, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.33% (275b3eb) to 45.46% (d0fee80) by +0.12%.

    FilenameBase (275b3eb)Merge (d0fee80)Diff
    AutoValue_FieldIndex_IndexOffset.java62.50%62.07%-0.43%
    FieldIndex.java98.08%98.18%+0.10%
    Index.java26.41%30.32%+3.91%
    LocalSerializer.java92.72%97.35%+4.64%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%
    SQLiteIndexManager.java99.07%99.07%+0.01%

Test Logs

Notes

  • Commit (d0fee80) is created by Prow via merging PR base commit (275b3eb) and head commit (b026796).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/suUn5FcO9z.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 19, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (275b3eb)Merge (c8b4dc6)Diff
    aar1.23 MB1.23 MB+272 B (+0.0%)
    apk (release)3.33 MB3.33 MB+292 B (+0.0%)

Test Logs

Notes

  • Commit (c8b4dc6) is created by Prow via merging PR base commit (275b3eb) and head commit (ff9146f).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oQZoXqhG3X.html

@schmidt-sebastian
Copy link
Contributor Author

/run binary-size

thebrianchen
thebrianchen approved these changes Jan 20, 2022
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

firebase-firestore/src/test/java/com/google/firebase/firestore/local/IndexBackfillerTest.java
@@ -289,7 +289,7 @@ private void addFieldIndex(String collectionGroup, String fieldName, SnapshotVer
fieldIndex(
collectionGroup,
FieldIndex.UNKNOWN_ID,
FieldIndex.IndexState.create(0, version, DocumentKey.empty()),
FieldIndex.IndexState.create(0, version, DocumentKey.empty(), -1),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: use INITIAL_LARGEST_BATCH_ID here and throughout

@schmidt-sebastian schmidt-sebastian merged commit 96a4b39 into master Jan 20, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/largestbatchid branch January 20, 2022 17:23
@firebase firebase locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen