Await foreground activity during sign in #3340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfkellogg
changed the title
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
rachaprince
reviewed
Jan 21, 2022
| * Returns a {@link SuccessContinuation} to be chained off of a {@link Task}, that will run | ||
| * another task in sequence and combine both results together. | ||
| * | ||
| * <p>This is useful when you want to run two tasks and use the results of each, but those tasks |
lfkellogg
force-pushed
the
lk/sign-in-intent-from-background
branch
3 times, most recently
from
37bd9f4 to
5731f60
Compare
lfkellogg
force-pushed
the
lk/sign-in-intent-from-background
branch
from
5731f60 to
053c019
Compare
lfkellogg
changed the title
lfkellogg
changed the title
|
Please hold off on reviewing, I think I need to tweak this a bit. |
lfkellogg
force-pushed
the
lk/sign-in-intent-from-background
branch
from
a5076fd to
c14fd98
Compare
lfkellogg
changed the title
|
OK this is ready for review |
| ErrorMessages.AUTHENTICATION_ERROR, AUTHENTICATION_FAILURE, e)); | ||
| }); | ||
| handleTaskFailure(ErrorMessages.AUTHENTICATION_ERROR, Status.AUTHENTICATION_FAILURE)) | ||
| .onSuccessTask(combineWithResultOf(() -> lifecycleNotifier.getForegroundActivity())) |
There was a problem hiding this comment.
Will this be ok in the case where we get the activity but we don't have the lock and once we get the lock the activity changes?
Foreground activity with no lock-> Lock granted -> Different foreground activity is now there but we continue now that we have the lock.
There was a problem hiding this comment.
Oh great catch! That would break. I'll see what I can do about that.
There was a problem hiding this comment.
I made a change in the success listener below, and left some clarifying comments. I think that helps but let me know what you think.
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/TaskUtils.java
Show resolved
Hide resolved
manny-jimenez
approved these changes
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.