Skip to content

Change device model for testlab #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

Change device model for testlab #3343

merged 1 commit into from
Jan 24, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 24, 2022

Flame (Pixel 4) does not support API 30 any longer (1), so we need to use Redfin

(1) According to gcloud firebase test android models list

@rlazo
Change device model for testlab
89dc5fb 
Flame (Pixel 4) does not support API 30 any longer (1), so we need to use Redfin

(1) According to `gcloud firebase test android models list`
@rlazo rlazo requested review from vkryachko and yifanyang January 24, 2022 20:44
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from ? (d1d5b47) to 9.74% (68df194) by ?.

    114 individual files with coverage change

    FilenameBase (d1d5b47)Merge (68df194)Diff
    AnalyticsDeferredProxy.java?0.00%?
    AnalyticsEventLogger.java?0.00%?
    AnalyticsEventReceiver.java?0.00%?
    AppData.java?56.25%?
    AppRequestData.java?0.00%?
    AppSettingsData.java?0.00%?
    AutoCrashlyticsReportEncoder.java?57.86%?
    AutoValue_CrashlyticsReport.java?0.00%?
    AutoValue_CrashlyticsReportWithSessionId.java?0.00%?
    AutoValue_CrashlyticsReport_ApplicationExitInfo.java?68.09%?
    AutoValue_CrashlyticsReport_CustomAttribute.java?0.00%?
    AutoValue_CrashlyticsReport_FilesPayload.java?0.00%?
    AutoValue_CrashlyticsReport_FilesPayload_File.java?0.00%?
    AutoValue_CrashlyticsReport_Session.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Application.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Application_Organization.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Device.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_BinaryImage.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Exception.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Signal.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Thread.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Application_Execution_Thread_Frame.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Device.java?0.00%?
    AutoValue_CrashlyticsReport_Session_Event_Log.java?0.00%?
    AutoValue_CrashlyticsReport_Session_OperatingSystem.java?0.00%?
    AutoValue_CrashlyticsReport_Session_User.java?0.00%?
    AutoValue_StaticSessionData.java?0.00%?
    AutoValue_StaticSessionData_AppData.java?6.00%?
    AutoValue_StaticSessionData_DeviceData.java?0.00%?
    AutoValue_StaticSessionData_OsData.java?0.00%?
    BackgroundPriorityRunnable.java?0.00%?
    BatteryState.java?0.00%?
    BlockingAnalyticsEventLogger.java?0.00%?
    BreadcrumbAnalyticsEventReceiver.java?0.00%?
    BreadcrumbHandler.java?0.00%?
    BreadcrumbSource.java?0.00%?
    BytesBackedNativeSessionFile.java?0.00%?
    CachedSettingsIo.java?0.00%?
    CLSUUID.java?0.00%?
    CommonUtils.java?0.00%?
    CrashlyticsAnalyticsListener.java?0.00%?
    CrashlyticsBackgroundWorker.java?56.25%?
    CrashlyticsController.java?18.65%?
    CrashlyticsCore.java?0.67%?
    CrashlyticsFileMarker.java?30.77%?
    CrashlyticsLifecycleEvents.java?0.00%?
    CrashlyticsNativeComponent.java?0.00%?
    CrashlyticsNativeComponentDeferredProxy.java?25.81%?
    CrashlyticsOriginAnalyticsEventLogger.java?0.00%?
    CrashlyticsRegistrar.java?0.00%?
    CrashlyticsReport.java?2.83%?
    CrashlyticsReportDataCapture.java?3.98%?
    CrashlyticsReportJsonTransform.java?1.24%?
    CrashlyticsReportPersistence.java?3.16%?
    CrashlyticsReportWithSessionId.java?0.00%?
    CrashlyticsUncaughtExceptionHandler.java?0.00%?
    CurrentTimeProvider.java?0.00%?
    CustomKeysAndValues.java?0.00%?
    DataCollectionArbiter.java?0.00%?
    DataTransportCrashlyticsReportSender.java?38.89%?
    DefaultSettingsJsonTransform.java?0.00%?
    DefaultSettingsSpiCall.java?0.00%?
    DeliveryMechanism.java?90.91%?
    DevelopmentPlatformProvider.java?0.00%?
    DisabledBreadcrumbSource.java?0.00%?
    ExecutorUtils.java?0.00%?
    FeaturesSettingsData.java?100.00%?
    FileBackedNativeSessionFile.java?0.00%?
    FileLogStore.java?0.00%?
    FileStore.java?29.17%?
    FirebaseCrashlytics.java?0.00%?
    HttpGetRequest.java?0.00%?
    HttpRequestFactory.java?0.00%?
    HttpResponse.java?0.00%?
    IdManager.java?3.13%?
    ImmutableList.java?0.00%?
    InstallerPackageNameProvider.java?0.00%?
    InstallIdProvider.java?0.00%?
    KeysMap.java?24.32%?
    LogFileManager.java?60.71%?
    Logger.java?40.54%?
    MetaDataStore.java?20.29%?
    MiddleOutFallbackStrategy.java?0.00%?
    MiddleOutStrategy.java?0.00%?
    NativeSessionFile.java?0.00%?
    NativeSessionFileGzipper.java?0.00%?
    NativeSessionFileProvider.java?0.00%?
    QueueFile.java?0.00%?
    QueueFileLogStore.java?7.58%?
    RemoveRepeatsStrategy.java?0.00%?
    ResponseParser.java?0.00%?
    SessionReportingCoordinator.java?45.39%?
    SessionSettingsData.java?0.00%?
    Settings.java?0.00%?
    SettingsCacheBehavior.java?0.00%?
    SettingsController.java?0.00%?
    SettingsData.java?0.00%?
    SettingsDataProvider.java?0.00%?
    SettingsJsonConstants.java?0.00%?
    SettingsJsonParser.java?0.00%?
    SettingsJsonTransform.java?0.00%?
    SettingsRequest.java?0.00%?
    SettingsSpiCall.java?0.00%?
    SettingsV3JsonTransform.java?0.00%?
    StackTraceTrimmingStrategy.java?0.00%?
    StaticSessionData.java?12.50%?
    SystemCurrentTimeProvider.java?0.00%?
    TrimmedThrowableData.java?0.00%?
    UnavailableAnalyticsEventLogger.java?0.00%?
    UserMetadata.java?25.93%?
    Utils.java?0.00%?

Test Logs

Notes

  • Commit (68df194) is created by Prow via merging PR base commit (d1d5b47) and head commit (89dc5fb).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PlxVDLFG3h.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (d1d5b47)Merge (68df194)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-annotations

    TypeBase (d1d5b47)Merge (68df194)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.83 kB? (?)

  • firebase-common

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?44.3 kB? (?)
    apk (aggressive)?77.8 kB? (?)
    apk (release)?635 kB? (?)

  • firebase-components

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)

  • firebase-crashlytics

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?338 kB? (?)
    apk (aggressive)?209 kB? (?)
    apk (release)?845 kB? (?)

  • firebase-encoders

    TypeBase (d1d5b47)Merge (68df194)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)

  • firebase-encoders-json

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?10.5 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?20.1 kB? (?)

  • firebase-encoders-proto

    TypeBase (d1d5b47)Merge (68df194)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?21.6 kB? (?)

  • firebase-installations

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?54.6 kB? (?)
    apk (aggressive)?79.5 kB? (?)
    apk (release)?657 kB? (?)

  • firebase-installations-interop

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?8.06 kB? (?)
    apk (aggressive)?55.4 kB? (?)
    apk (release)?607 kB? (?)

  • transport-api

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?6.57 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?14.9 kB? (?)

  • transport-backend-cct

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?53.5 kB? (?)
    apk (aggressive)?58.0 kB? (?)
    apk (release)?105 kB? (?)

  • transport-runtime

    TypeBase (d1d5b47)Merge (68df194)Diff
    aar?178 kB? (?)
    apk (aggressive)?43.8 kB? (?)
    apk (release)?82.6 kB? (?)

Test Logs

Notes

  • Commit (68df194) is created by Prow via merging PR base commit (d1d5b47) and head commit (89dc5fb).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rRW72GvgsA.html

@rlazo rlazo merged commit f620db9 into master Jan 24, 2022
@rlazo rlazo deleted the rlazo-patch-1 branch January 24, 2022 21:03
@yoyomyo yoyomyo mentioned this pull request Jan 24, 2022
Merged
rlazo added a commit that referenced this pull request Jan 25, 2022
@rlazo
Update macrobenchmark to use the right device
7ba79bf 
This is a follow up to #3343 which made the change for crashlytics.
@rlazo rlazo mentioned this pull request Jan 25, 2022
Merged
rlazo added a commit that referenced this pull request Jan 25, 2022
@rlazo
Update macrobenchmark to use the right device (#3346)
6090f1e 
This is a follow up to #3343 which made the change for crashlytics.
@firebase firebase locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yifanyang yifanyang yifanyang approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @yifanyang