Skip to content

Misc indexing fixes #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2022
Merged

Misc indexing fixes #3351

merged 2 commits into from
Jan 26, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.41% (f25efea) to 45.36% (fec0c70) by -0.05%.

    FilenameBase (f25efea)Merge (fec0c70)Diff
    GrpcCallProvider.java60.23%46.59%-13.64%
    SetMutation.java94.29%97.14%+2.86%
    Target.java96.08%96.04%-0.04%

Test Logs

Notes

  • Commit (fec0c70) is created by Prow via merging PR base commit (f25efea) and head commit (19f90cb).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ivpmkzjoBi.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (f25efea)Merge (fec0c70)Diff
    aar1.24 MB1.24 MB-20 B (-0.0%)
    apk (release)3.33 MB3.33 MB-76 B (-0.0%)

Test Logs

Notes

  • Commit (fec0c70) is created by Prow via merging PR base commit (f25efea) and head commit (19f90cb).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZwyKp9M2ku.html

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Jan 26, 2022
@schmidt-sebastian
Copy link
Contributor Author

/retest

@schmidt-sebastian schmidt-sebastian merged commit 579a83e into master Jan 26, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/miscindexingfixes branch January 26, 2022 19:39
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui