Skip to content

Remove an unused method #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2022
Merged

Remove an unused method #3367

merged 1 commit into from
Jan 26, 2022

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (aafced0) to 73.80% (2d01d33) by ?.

    34 individual files with coverage change

    FilenameBase (aafced0)Merge (2d01d33)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?74.22%?
    AppDistributionRelease.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionRelease.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?67.86%?
    AutoValue_TaskUtils_CombinedTaskResults.java?33.33%?
    AutoValue_UpdateProgress.java?65.96%?
    BinaryType.java?100.00%?
    Constants.java?0.00%?
    FirebaseAppDistribution.java?95.65%?
    FirebaseAppDistributionException.java?88.24%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?36.71%?
    FirebaseAppDistributionNotificationsManager.java?92.68%?
    FirebaseAppDistributionRegistrar.java?90.91%?
    FirebaseAppDistributionTesterApiClient.java?91.21%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?64.71%?
    NewReleaseFetcher.java?87.95%?
    OnProgressListener.java?0.00%?
    ReleaseIdentificationUtils.java?15.52%?
    ReleaseUtils.java?76.92%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?94.29%?
    TesterSignInManager.java?93.75%?
    UpdateProgress.java?100.00%?
    UpdateStatus.java?100.00%?
    UpdateTask.java?100.00%?
    UpdateTaskImpl.java?82.81%?

Test Logs

Notes

  • Commit (2d01d33) is created by Prow via merging PR base commit (aafced0) and head commit (30e8f16).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ynGGCsR2xa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (aafced0)Merge (2d01d33)Diff
    aar125 kB124 kB-109 B (-0.1%)
    apk (release)1.55 MB1.55 MB+52 B (+0.0%)

Test Logs

Notes

  • Commit (2d01d33) is created by Prow via merging PR base commit (aafced0) and head commit (30e8f16).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/i7HyUl8pc8.html

@lfkellogg
Copy link
Contributor Author

/retest

@lfkellogg lfkellogg merged commit 9a66b0e into master Jan 26, 2022
@lfkellogg lfkellogg deleted the lk/remove-unused branch January 26, 2022 15:38
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manny-jimenez manny-jimenez manny-jimenez approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @manny-jimenez