Skip to content

Backport readTime changes #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

Backporting some of the changes in firebase/firebase-js-sdk#5925 that were not already part of Android.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.35% (d1fc101) to 45.34% (66aaef9) by -0.01%.

    FilenameBase (d1fc101)Merge (66aaef9)Diff
    DocumentKey.java100.00%97.14%-2.86%
    LocalStore.java99.37%99.35%-0.01%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.14%94.29%-2.86%
    WatchChangeAggregator.java98.18%98.21%+0.03%

Test Logs

Notes

  • Commit (66aaef9) is created by Prow via merging PR base commit (d1fc101) and head commit (686c4b3).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b1wVN31w0h.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (d1fc101)Merge (66aaef9)Diff
    aar1.24 MB1.24 MB-49 B (-0.0%)
    apk (release)3.33 MB3.33 MB-240 B (-0.0%)

Test Logs

Notes

  • Commit (66aaef9) is created by Prow via merging PR base commit (d1fc101) and head commit (686c4b3).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yt3YanxX1u.html

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 686c4b3 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Jan 31, 2022
@schmidt-sebastian schmidt-sebastian merged commit 88ea99b into master Jan 31, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/simplifyreadtime branch January 31, 2022 18:11
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants