Skip to content

Removing unused status #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Removing unused status #3389

merged 3 commits into from
Feb 2, 2022

Conversation

manny-jimenez
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2022

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 76.45% (486da83) to 76.42% (47bf8e2) by -0.03%.

    FilenameBase (486da83)Merge (47bf8e2)Diff
    FirebaseAppDistributionException.java88.57%87.88%-0.69%
  • firebase-appdistribution-stub

    Overall coverage changed from 19.66% (486da83) to 18.75% (47bf8e2) by -0.91%.

Test Logs

Notes

  • Commit (47bf8e2) is created by Prow via merging PR base commit (486da83) and head commit (719757e).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bPPDywi5ya.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2022

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (486da83)Merge (47bf8e2)Diff
    aar124 kB123 kB-93 B (-0.1%)
    apk (release)1.55 MB1.55 MB-76 B (-0.0%)
  • firebase-appdistribution-stub

    TypeBase (486da83)Merge (47bf8e2)Diff
    aar17.6 kB17.5 kB-91 B (-0.5%)
    apk (release)612 kB612 kB-68 B (-0.0%)

Test Logs

Notes

  • Commit (47bf8e2) is created by Prow via merging PR base commit (486da83) and head commit (719757e).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/25qeq8Lu44.html

Copy link
Contributor

@lfkellogg lfkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these from the stub API as well?

@manny-jimenez
Copy link
Contributor Author

/test smoke-tests

@google-oss-bot
Copy link
Contributor

@mannyjimenez0810: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 719757e link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@manny-jimenez manny-jimenez merged commit 2db9b55 into master Feb 2, 2022
@manny-jimenez manny-jimenez deleted the fad-remove-unsued-enums branch February 2, 2022 19:55
@firebase firebase locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants