Fix the way of gzipping and base64. This is now consistent with server #3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected Products
Test Logs
Notes |
Coverage Report 1Affected Products
Test Logs
Notes |
VinayGuthal
changed the title
vkryachko
reviewed
Feb 15, 2022
firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java
Outdated
Show resolved
Hide resolved
...e-common/src/test/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatControllerTest.java
Show resolved
Hide resolved
vkryachko
reviewed
Feb 15, 2022
firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java
Outdated
Show resolved
Hide resolved
firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java
Outdated
Show resolved
Hide resolved
vkryachko
reviewed
Feb 15, 2022
Comment on lines
+208
to
+214
| ByteArrayOutputStream byteOutputStream = new ByteArrayOutputStream(); | ||
| try { | ||
| try (GZIPOutputStream gzipOutputStream = new GZIPOutputStream(byteOutputStream)) { | ||
| gzipOutputStream.write(input.getBytes(UTF_8)); | ||
| } | ||
| byte[] gzipped = byteOutputStream.toByteArray(); | ||
| byteOutputStream.close(); |
There was a problem hiding this comment.
Looks like you can use try with resources here as well
There was a problem hiding this comment.
it complains saying byte[] is not a proper type for try with resources.
There was a problem hiding this comment.
AFAIK not closing it is OK.
https://docs.oracle.com/javase/7/docs/api/java/io/ByteArrayOutputStream.html#close()
Closing a ByteArrayOutputStream has no effect. The methods in this class can be called after the stream has been closed without generating an IOException.
vkryachko
approved these changes
Feb 18, 2022
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 9, 2022
#3414) * push test pr * fix platform logging header request * small fixes * use try * fix tests * use strings * update * gJF
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the way of gzipping and base64. This is now consistent with server. Tests added to the server side as well.