Skip to content

Use tryWithResources #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Use tryWithResources #3421

merged 1 commit into from
Feb 8, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.51% (149529a) to 45.51% (b3dbc1e) by -0.01%.

    FilenameBase (149529a)Merge (b3dbc1e)Diff
    DeleteMutation.java90.00%95.00%+5.00%
    PatchMutation.java98.39%100.00%+1.61%
    SQLitePersistence.java86.84%86.34%-0.50%

Test Logs

Notes

  • Commit (b3dbc1e) is created by Prow via merging PR base commit (149529a) and head commit (fa4275a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lbN3xZYEM1.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (149529a)Merge (b3dbc1e)Diff
    aar1.24 MB1.24 MB+19 B (+0.0%)
    apk (release)3.33 MB3.33 MB-40 B (-0.0%)

Test Logs

Notes

  • Commit (b3dbc1e) is created by Prow via merging PR base commit (149529a) and head commit (fa4275a).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wwCTlnlM9y.html

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests fa4275a link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit 7f09987 into master Feb 8, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/encodingerror branch February 8, 2022 21:56
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@firebase firebase locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants