Skip to content

App Distribution Reference Docs Edits #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 22, 2022
Merged

App Distribution Reference Docs Edits #3427

merged 10 commits into from
Feb 22, 2022

Conversation

rachaprince
Copy link

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (f8c28ca) to 76.55% (da2a0be) by ?.

    32 individual files with coverage change

    FilenameBase (f8c28ca)Merge (da2a0be)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?73.44%?
    AppDistributionRelease.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionRelease.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?67.86%?
    AutoValue_UpdateProgress.java?65.96%?
    BinaryType.java?100.00%?
    FirebaseAppDistribution.java?94.58%?
    FirebaseAppDistributionException.java?84.85%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?73.68%?
    FirebaseAppDistributionNotificationsManager.java?92.68%?
    FirebaseAppDistributionRegistrar.java?90.91%?
    FirebaseAppDistributionTesterApiClient.java?91.40%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?64.71%?
    NewReleaseFetcher.java?87.95%?
    OnProgressListener.java?0.00%?
    ReleaseIdentificationUtils.java?15.52%?
    ReleaseUtils.java?76.92%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?92.86%?
    TesterSignInManager.java?93.68%?
    UpdateProgress.java?100.00%?
    UpdateStatus.java?100.00%?
    UpdateTask.java?100.00%?
    UpdateTaskImpl.java?82.81%?

Test Logs

Notes

  • Commit (da2a0be) is created by Prow via merging PR base commit (f8c28ca) and head commit (3793c4d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8ourtRZJ8l.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2022 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-annotations

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.83 kB? (?)

  • firebase-appdistribution

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    aar?124 kB? (?)
    apk (aggressive)?744 kB? (?)
    apk (release)?1.57 MB? (?)

  • firebase-common

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    aar?48.0 kB? (?)
    apk (aggressive)?84.3 kB? (?)
    apk (release)?680 kB? (?)

  • firebase-components

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)

  • firebase-installations

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?85.8 kB? (?)
    apk (release)?702 kB? (?)

  • firebase-installations-interop

    TypeBase (f8c28ca)Merge (da2a0be)Diff
    aar?8.34 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

Notes

  • Commit (da2a0be) is created by Prow via merging PR base commit (f8c28ca) and head commit (3793c4d).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/00LFxlFXaW.html

@rachaprince rachaprince changed the title Small syntax fixes; Standardize use of period in java docs App Distribution Reference Docs Edits Feb 10, 2022
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution:
error: Removed enum constant com.google.firebase.appdistribution.FirebaseAppDistributionException.Status.APP_RUNNING_IN_PRODUCTION [RemovedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution:
error: Removed enum constant com.google.firebase.appdistribution.FirebaseAppDistributionException.Status.APP_RUNNING_IN_PRODUCTION [RemovedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

@rachaprince: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 3793c4d link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@manny-jimenez manny-jimenez self-requested a review February 22, 2022 14:59
@rachaprince rachaprince merged commit 706561b into master Feb 22, 2022
@rachaprince rachaprince deleted the fad-reference-docs branch February 22, 2022 15:00
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@jeremyjiang-dev
App Distribution Reference Docs Edits (#3427)
4e622f9 
* Small syntax fixes; Standardize use of period in java docs

* Improved error messages with error resolution guidance.

* Fix formatting

* Add resolution messages to ErrorMessages

* Fix formatting

* Update API and fix tests

* Make java doc tense and language more consistent

* Fix grammar
@firebase firebase locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

@manny-jimenez manny-jimenez manny-jimenez approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachaprince @google-oss-bot @lfkellogg @manny-jimenez