Add version name to header #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs
Notes |
rachaprince
force-pushed
the
fad-client-version-metrics
branch
from
d1626a0 to
4f6ff89
Compare
rachaprince
commented
Feb 10, 2022
| @@ -210,6 +212,8 @@ private HttpsURLConnection openHttpsUrlConnection( | |||
| httpsURLConnection.addRequestProperty(X_ANDROID_PACKAGE_HEADER_KEY, context.getPackageName()); | |||
| httpsURLConnection.addRequestProperty( | |||
| X_ANDROID_CERT_HEADER_KEY, getFingerprintHashForPackage(context)); | |||
| httpsURLConnection.addRequestProperty( | |||
| X_CLIENT_VERSION_HEADER_KEY, String.format("android-sdk/%s", BuildConfig.VERSION_NAME)); | |||
There was a problem hiding this comment.
See https://developer.android.com/studio/build/gradle-tips#share-custom-fields-and-resource-values-with-your-app-code and Crashlytics usage of this field here:
lfkellogg
approved these changes
Feb 10, 2022
...rc/main/java/com/google/firebase/appdistribution/FirebaseAppDistributionTesterApiClient.java
Show resolved
Hide resolved
| @@ -69,7 +71,7 @@ | |||
| } | |||
|
|
|||
| /** | |||
| * Fetches and returns the lastest release for the app that the tester has access to, or null if | |||
| * Fetches and returns the latest release for the app that the tester has access to, or null if | |||
manny-jimenez
approved these changes
Feb 10, 2022
Size Report 1Affected Products
Test Logs
Notes |
lfkellogg
approved these changes
Feb 10, 2022
qdpham13
pushed a commit
that referenced
this pull request
Feb 15, 2022
* Add version name to header * move comment above declaration
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 9, 2022
* Add version name to header * move comment above declaration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds version name to the header for adoption metrics
Screenshot from the networks tab of Android Studio:
