Skip to content

Refine the project setup for SDK health metrics #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 24, 2022
Merged

Refine the project setup for SDK health metrics #3438

merged 10 commits into from
Feb 24, 2022

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Feb 12, 2022 •
edited
Loading

  • Reword languages in README and link to the health metrics page on Firebase devsite
  • Move folders for size and macrobenchmark to health-metrics under project root

See http://b/216869761 for more details.

@yifanyang
Refine the project setup for SDK health metrics
7091314 
- Reword languages in README and link to the health metrics page on Firebase devsite
- Move folders for size and macrobenchmark to `health-metrics` under project root
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.14% (cf15a6b) to 50.19% (67be24f) by +0.04%.

    FilenameBase (cf15a6b)Merge (67be24f)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 45.57% (cf15a6b) to 45.59% (67be24f) by +0.01%.

    FilenameBase (cf15a6b)Merge (67be24f)Diff
    DeleteMutation.java90.00%95.00%+5.00%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%

  • firebase-messaging

    Overall coverage changed from 85.50% (cf15a6b) to 85.54% (67be24f) by +0.04%.

    FilenameBase (cf15a6b)Merge (67be24f)Diff
    FirebaseMessaging.java74.67%75.11%+0.44%

Test Logs

Notes

  • Commit (67be24f) is created by Prow via merging PR base commit (cf15a6b) and head commit (a7d1846).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GcXaSRxshH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 14, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (cf15a6b) and merge commit (67be24f).

Test Logs

Notes

  • Commit (67be24f) is created by Prow via merging PR base commit (cf15a6b) and head commit (a7d1846).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Hfsn7b6GiE.html

@yifanyang
Copy link
Contributor Author

/test macrobenchmark

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 14, 2022 •
edited
Loading

Macrobenchmark Report 1

Diffing between the merge commit (76c327d) and the base commit (494453a) is still work-in-progress. Please refer to test logs to find more details on benchmark measurements.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hhXZ16KWpD.html

@yifanyang
Copy link
Contributor Author

/test fireci

@yifanyang
Copy link
Contributor Author

/test macrobenchmark

@yifanyang
Copy link
Contributor Author

/test macrobenchmark

@yifanyang yifanyang requested review from vkryachko and rlazo February 16, 2022 04:59
rlazo
rlazo reviewed Feb 18, 2022
View reviewed changes
yifanyang and others added 2 commits February 24, 2022 09:42
@yifanyang
Copy link
Contributor Author

/test smoke-tests

1 similar comment
@yifanyang
Copy link
Contributor Author

/test smoke-tests

@google-oss-bot
Copy link
Contributor

@yifanyang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed a7d1846 link /test device-check-changed
smoke-tests a7d1846 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang merged commit 1011a66 into master Feb 24, 2022
@yifanyang yifanyang deleted the yifany/readme branch February 24, 2022 20:27
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@yifanyang @jeremyjiang-dev
Refine the project setup for SDK health metrics (#3438)
e398381 
* Refine the project setup for SDK health metrics

- Reword languages in README and link to the health metrics page on Firebase devsite
- Move folders for size and macrobenchmark to `health-metrics` under project root
@firebase firebase locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yifanyang @google-oss-bot @rlazo