Skip to content

call DROP_GLOBAL_LOG_EVENT_STATE_SQL before inserting during migration #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

call DROP_GLOBAL_LOG_EVENT_STATE_SQL before inserting during migration #3460

merged 1 commit into from
Feb 22, 2022

Conversation

argzdev
Copy link
Contributor

@argzdev argzdev commented Feb 17, 2022

Proposed fix for #3459 by danyalberton.

The DROP_GLOBAL_LOG_EVENT_STATE_SQL is only called during onDowngrade, which means if somehow the migration fails half way, there is no way of continuing the migration, thus it's best to call DROP_GLOBAL_LOG_EVENT_STATE_SQL whenever creating the table to ensure this table does not exist before upgrade.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • transport-runtime

    Overall coverage changed from 55.42% (6e96da6) to 55.44% (d12970b) by +0.02%.

    FilenameBase (6e96da6)Merge (d12970b)Diff
    SchemaManager.java98.48%98.51%+0.02%

Test Logs

Notes

  • Commit (d12970b) is created by Prow via merging PR base commit (6e96da6) and head commit (62fa359).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BmVZnSajrS.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • transport-runtime

    TypeBase (6e96da6)Merge (d12970b)Diff
    aar178 kB178 kB+7 B (+0.0%)
    apk (aggressive)43.8 kB43.8 kB-4 B (-0.0%)
    apk (release)82.6 kB82.6 kB+8 B (+0.0%)

Test Logs

Notes

  • Commit (d12970b) is created by Prow via merging PR base commit (6e96da6) and head commit (62fa359).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/W7mDGNtbxe.html

danyalberton
danyalberton approved these changes Feb 18, 2022
View reviewed changes
Copy link

@danyalberton danyalberton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this changes that resolve a problem during library update.

@vkryachko vkryachko merged commit f793d77 into firebase:master Feb 22, 2022
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@argzdev @jeremyjiang-dev
call DROP_GLOBAL_LOG_EVENT_STATE_SQL before inserting during migration (
c04b12d 
#3460)
@firebase firebase locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@danyalberton danyalberton danyalberton approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@argzdev @google-oss-bot @vkryachko @danyalberton