Skip to content

Revert "Re-establish streams when App Check token expires. (#3328)" #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

Revert "Re-establish streams when App Check token expires. (#3328)" #3462

merged 1 commit into from
Feb 17, 2022

Conversation

ehsannas
Copy link
Contributor

This reverts commit 26d0992.

@ehsannas ehsannas self-assigned this Feb 17, 2022
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (d54c7c0)Merge (03fc110)Diff
    aar1.24 MB1.24 MB-116 B (-0.0%)
    apk (release)3.37 MB3.37 MB-248 B (-0.0%)

Test Logs

Notes

  • Commit (03fc110) is created by Prow via merging PR base commit (d54c7c0) and head commit (8b3299c).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NSYq6ioqXu.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.55% (d54c7c0) to 45.56% (03fc110) by +0.02%.

    FilenameBase (d54c7c0)Merge (03fc110)Diff
    FirestoreClient.java30.22%31.11%+0.90%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%

Test Logs

Notes

  • Commit (03fc110) is created by Prow via merging PR base commit (d54c7c0) and head commit (8b3299c).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OPk6Wj6XJy.html

@ehsannas
Copy link
Contributor Author

/retest

@ehsannas ehsannas merged commit 62d868a into master Feb 17, 2022
@ehsannas ehsannas deleted the ehsann/revert-3328 branch February 17, 2022 19:38
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@ehsannas @jeremyjiang-dev
Revert "Re-establish streams when App Check token expires. (#3328)" (#…
145aaae 
…3462)

This reverts commit 26d0992.
@firebase firebase locked and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@ehsannas ehsannas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian