Skip to content

- Changes to protoc version to make it working for m1 macs. #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 13, 2022
Merged

- Changes to protoc version to make it working for m1 macs. #3479

merged 19 commits into from
Apr 13, 2022

Conversation

eldhosembabu
Copy link
Contributor

@eldhosembabu eldhosembabu commented Feb 24, 2022 •
edited
Loading

  • Changes to protoc version to make it working for m1 macs.

protoc v3.17.3 changelog: https://github.com/protocolbuffers/protobuf/releases/tag/v3.17.3

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (dcd2042)Merge (90c204a)Diff
    aar1.25 MB1.25 MB+3.51 kB (+0.3%)
    apk (release)3.38 MB3.38 MB-1.31 kB (-0.0%)

  • firebase-firestore-ktx

    TypeBase (dcd2042)Merge (90c204a)Diff
    apk (release)3.86 MB3.87 MB+956 B (+0.0%)

  • firebase-inappmessaging

    TypeBase (dcd2042)Merge (90c204a)Diff
    aar469 kB470 kB+1.56 kB (+0.3%)
    apk (release)3.41 MB3.41 MB+276 B (+0.0%)

  • firebase-inappmessaging-display

    TypeBase (dcd2042)Merge (90c204a)Diff
    apk (release)4.67 MB4.67 MB+584 B (+0.0%)

  • firebase-inappmessaging-display-ktx

    TypeBase (dcd2042)Merge (90c204a)Diff
    apk (release)5.17 MB5.17 MB+352 B (+0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (dcd2042)Merge (90c204a)Diff
    apk (release)3.90 MB3.90 MB+264 B (+0.0%)

  • firebase-perf

    TypeBase (dcd2042)Merge (90c204a)Diff
    aar307 kB308 kB+902 B (+0.3%)
    apk (aggressive)1.03 MB1.03 MB+76 B (+0.0%)
    apk (release)2.47 MB2.47 MB+1.33 kB (+0.1%)

  • firebase-perf-ktx

    TypeBase (dcd2042)Merge (90c204a)Diff
    apk (aggressive)1.04 MB1.04 MB+216 B (+0.0%)
    apk (release)2.94 MB2.94 MB+780 B (+0.0%)

  • protolite-well-known-types

    TypeBase (dcd2042)Merge (90c204a)Diff
    aar993 kB1.00 MB+6.73 kB (+0.7%)
    apk (release)661 kB663 kB+1.68 kB (+0.3%)

Test Logs

Notes

  • Commit (90c204a) is created by Prow via merging PR base commit (dcd2042) and head commit (b155fe7).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nAIgXKGh0f.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (dcd2042) to 50.17% (90c204a) by -0.04%.

    FilenameBase (dcd2042)Merge (90c204a)Diff
    BooleanNode.java100.00%92.31%-7.69%
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    ViewProcessor.java91.79%92.10%+0.30%

  • firebase-firestore

    Overall coverage changed from 46.28% (dcd2042) to 46.20% (90c204a) by -0.08%.

    FilenameBase (dcd2042)Merge (90c204a)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    DocumentTransform.java29.44%29.31%-0.13%
    Index.java30.32%30.02%-0.29%
    ListenRequest.java10.77%10.66%-0.11%
    PatchMutation.java100.00%98.39%-1.61%
    Precondition.java38.46%37.82%-0.65%
    Value.java42.48%40.97%-1.51%
    Write.java36.56%36.11%-0.45%

  • firebase-inappmessaging

    Overall coverage changed from 37.62% (dcd2042) to 37.61% (90c204a) by -0.01%.

    FilenameBase (dcd2042)Merge (90c204a)Diff
    CommonTypesProto.java9.98%9.96%-0.02%

  • firebase-perf

    Overall coverage changed from ? (dcd2042) to 71.46% (90c204a) by ?.

    100 individual files with coverage change

    FilenameBase (dcd2042)Merge (90c204a)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?86.54%?
    AppStateMonitor.java?88.57%?
    AppStateUpdateHandler.java?92.86%?
    Clock.java?100.00%?
    ConfigResolver.java?97.38%?
    ConfigurationConstants.java?99.25%?
    ConfigurationFlag.java?100.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.03%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.57%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?33.33%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfProvider.java?76.92%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?89.01%?
    FirebasePerfUrlConnection.java?44.26%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?91.67%?
    FrameMetricsCalculator.java?96.30%?
    GaugeManager.java?98.43%?
    GaugeMetadata.java?32.21%?
    GaugeMetadataManager.java?84.21%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?91.78%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?91.38%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?90.32%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    Rate.java?100.00%?
    RateLimiter.java?90.98%?
    RemoteConfigManager.java?92.86%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?93.75%?
    Trace.java?96.69%?
    TraceMetric.java?43.98%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?95.81%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-storage

    Overall coverage changed from 85.89% (dcd2042) to 85.85% (90c204a) by -0.04%.

    FilenameBase (dcd2042)Merge (90c204a)Diff
    UploadTask.java80.94%80.58%-0.36%

Test Logs

Notes

  • Commit (90c204a) is created by Prow via merging PR base commit (dcd2042) and head commit (b155fe7).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BDGbcIs7m1.html

@eldhosembabu eldhosembabu requested a review from rlazo February 24, 2022 18:57
@rlazo
Copy link
Collaborator

rlazo commented Feb 25, 2022

/test check-changed

@eldhosembabu
Copy link
Contributor Author

/retest

@eldhosembabu
Copy link
Contributor Author

/test check-changed

@eldhosembabu eldhosembabu requested a review from rlazo March 1, 2022 09:19
@eldhosembabu
Copy link
Contributor Author

/test check-changed

@google-oss-bot
Copy link
Contributor

@eldhosembabu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests b155fe7 link /test smoke-tests
device-check-changed b155fe7 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator

rlazo commented Apr 13, 2022

Hi @eldhosembabu the issues in the tests are not related to the change. Feel free to merge your change. Thanks and sorry for the delay!

@schmidt-sebastian
Copy link
Contributor

Merging this to unblock M1 development. Thanks!

@schmidt-sebastian schmidt-sebastian merged commit 6e788ac into master Apr 13, 2022
@schmidt-sebastian schmidt-sebastian deleted the m1-mac-fixes branch April 13, 2022 16:06
@eldhosembabu
Copy link
Contributor Author

Thanks @rlazo and @schmidt-sebastian !

@firebase firebase locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldhosembabu @google-oss-bot @rlazo @schmidt-sebastian