Skip to content

Don't generate javadoc for internal code in directboot. #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Feb 24, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2022

Coverage Report 1

Affected Products

No changes between base commit (9adbd59) and merge commit (a000e11).

Test Logs

Notes

  • Commit (a000e11) is created by Prow via merging PR base commit (9adbd59) and head commit (39b2501).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Xj56vnNQPN.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-messaging-directboot:
error: Removed package com.google.firebase.messaging.directboot.threads [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2022

@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 39b2501 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit cd01614 into master Feb 24, 2022
@rlazo rlazo deleted the rl.direct-boot-hid-9181 branch February 24, 2022 21:08
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
* Don't generate javadoc for internal code in directboot.

* Update api.txt
@firebase firebase locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants