Skip to content

App Check as a heartbeat Consumer since backend works now #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

VinayGuthal
Copy link
Contributor

App check as a heartbeat consumer since the e2e test for the app check backend works with android

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2022

Coverage Report 1

Affected Products

  • firebase-appcheck

    Overall coverage changed from 81.01% (5c69cfc) to 81.05% (cb9692c) by +0.04%.

Test Logs

Notes

  • Commit (cb9692c) is created by Prow via merging PR base commit (5c69cfc) and head commit (17fb70e).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aY0RR70aJ6.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2022

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (5c69cfc)Merge (cb9692c)Diff
    aar37.1 kB37.1 kB+24 B (+0.1%)
    apk (aggressive)330 kB330 kB+76 B (+0.0%)
    apk (release)973 kB973 kB+124 B (+0.0%)

Test Logs

Notes

  • Commit (cb9692c) is created by Prow via merging PR base commit (5c69cfc) and head commit (17fb70e).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HB6SMdHh3Y.html

@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 17fb70e link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VinayGuthal VinayGuthal merged commit f5845b2 into master Mar 15, 2022
@VinayGuthal VinayGuthal deleted the appcheck_Register_heartbeat branch March 15, 2022 17:49
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants