Skip to content

Fireperf: start screen trace in onResume #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Conversation

leotianlizhan
Copy link
Contributor

@leotianlizhan leotianlizhan commented Mar 15, 2022

followup to #3311

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 15, 2022

Coverage Report 1

Affected Products

No changes between base commit (525b580) and merge commit (59a4554).

Test Logs

Notes

  • Commit (59a4554) is created by Prow via merging PR base commit (525b580) and head commit (b00bf17).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7yACRyCfoJ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 15, 2022

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (525b580)Merge (59a4554)Diff
    aar302 kB302 kB-12 B (-0.0%)
    apk (aggressive)982 kB982 kB-40 B (-0.0%)
    apk (release)2.46 MB2.46 MB+268 B (+0.0%)

Test Logs

Notes

  • Commit (59a4554) is created by Prow via merging PR base commit (525b580) and head commit (b00bf17).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6tfkbw1gO5.html

@leotianlizhan
Copy link
Contributor Author

/test smoke-tests

@leotianlizhan
Copy link
Contributor Author

/retest

@leotianlizhan
Copy link
Contributor Author

smoke-tests failed with

Execution failed for task ':preDebugBuild'.
> Could not resolve all files for configuration ':debugCompileClasspath'.
   > Could not find com.google.firebase:firebase-appdistribution:.
     Required by:
         project :

Since it's unrelated, tempted to just merge.

@leotianlizhan
Copy link
Contributor Author

/retest

@google-oss-bot
Copy link
Contributor

@leotianlizhan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests b00bf17 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leotianlizhan leotianlizhan merged commit a9ffa8b into master Mar 21, 2022
@leotianlizhan leotianlizhan deleted the screen-trace-resume branch March 21, 2022 22:07
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
* move screen trace start to onResum

* gjf

* comment

* fix tests
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
* move screen trace start to onResum

* gjf

* comment

* fix tests
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
* move screen trace start to onResum

* gjf

* comment

* fix tests
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
* move screen trace start to onResum

* gjf

* comment

* fix tests
@firebase firebase locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants