Skip to content

Fix overlay bug when offline #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Fix overlay bug when offline #3537

merged 5 commits into from
Mar 16, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Mar 15, 2022

Fix: #3528

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 15, 2022

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.63% (f5845b2) to 45.66% (834eec2) by +0.03%.

    FilenameBase (f5845b2)Merge (834eec2)Diff
    AsyncQueue.java77.11%78.11%+1.00%
    LocalStore.java99.35%99.37%+0.02%
    MutationBatch.java89.06%89.23%+0.17%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

Notes

  • Commit (834eec2) is created by Prow via merging PR base commit (f5845b2) and head commit (0ff7ae7).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/D4i3gvE32s.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 15, 2022

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (f5845b2)Merge (834eec2)Diff
    aar1.24 MB1.24 MB+333 B (+0.0%)
    apk (release)3.38 MB3.38 MB-272 B (-0.0%)

Test Logs

Notes

  • Commit (834eec2) is created by Prow via merging PR base commit (f5845b2) and head commit (0ff7ae7).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TsujZH8Sqk.html

Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a change log entry. Also, please apply the feedback from @schmidt-sebastian, if any.

@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Mar 15, 2022
wu-hui added 2 commits March 15, 2022 16:40
# Conflicts:
#	firebase-firestore/CHANGELOG.md
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@google-oss-bot
Copy link
Contributor

@wu-hui: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 0ff7ae7 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wu-hui
Copy link
Contributor Author

wu-hui commented Mar 15, 2022

This PR needs a change log entry. Also, please apply the feedback from @schmidt-sebastian, if any.

Done.

@wu-hui wu-hui merged commit df21954 into master Mar 16, 2022
@wu-hui wu-hui deleted the wuandy/OverlayOfflineFix branch March 16, 2022 00:48
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloud_firestore] Snapshot lost all attributes data after offline updates
4 participants