-
Notifications
You must be signed in to change notification settings - Fork 624
Fix overlay bug when offline #3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs a change log entry. Also, please apply the feedback from @schmidt-sebastian, if any.
# Conflicts: # firebase-firestore/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/model/mutation/Mutation.java
Outdated
Show resolved
Hide resolved
@wu-hui: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Done. |
Fix: #3528