Firestore: Migrate unit tests to assertThrows() #3562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected ProductsNo changes between base commit (e3ae02d) and merge commit (69d06a0).Test Logs
Notes |
|
/test smoke-tests |
1 similar comment
|
/test smoke-tests |
dconeybe
requested review from
schmidt-sebastian
and removed request for
wu-hui
dconeybe
assigned
schmidt-sebastian and
wu-hui and unassigned
wu-hui and
schmidt-sebastian
dconeybe
requested review from
wu-hui
and removed request for
schmidt-sebastian
wu-hui
approved these changes
Mar 23, 2022
…ualsTrueToAssertThrows
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 24, 2022
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 25, 2022
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 25, 2022
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Firestore unit tests were using the problematic
@Test(expected = Exception.class)annotation to test for expected exceptions. This pattern, however, is problematic because it can easily hide test failures if some other part of the test were to throw the expected exception type (or any subclass thereof). UsingassertThrows()is far less problematic because it only checks exceptions of a specific block of code, not the entire test case. This PR converts Firestore unit tests to useassertThrows(). Googlers can see go/lsc-assertthrows and go/assertthrows for more details.