Skip to content

Catch RuntimeException when getting analytics Bundle. #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

Catch RuntimeException when getting analytics Bundle. #3564

merged 1 commit into from
Mar 18, 2022

Conversation

gsakakihara
Copy link
Contributor

#3538

  • Added catching RuntimeException when trying to get the analytics data Bundle from the Activity Intent since it's possible that the extras could contain invalid or incorrectly formatted data that will throw an Exception when trying to get the Bundle.

@gsakakihara
Catch RuntimeException when getting analytics Bundle.
6d22c53 
#3538
* Added catching RuntimeException when trying to get the analytics data Bundle from the Activity Intent since it's possible that the extras could contain invalid or incorrectly formatted data that will throw an Exception when trying to get the Bundle.
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.97% (63efd46) to 84.92% (ef9134e) by -0.05%.

    FilenameBase (63efd46)Merge (ef9134e)Diff
    FcmLifecycleCallbacks.java95.83%89.29%-6.55%

Test Logs

Notes

  • Commit (ef9134e) is created by Prow via merging PR base commit (63efd46) and head commit (6d22c53).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vsnnOreBAE.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (63efd46)Merge (ef9134e)Diff
    aar225 kB225 kB+163 B (+0.1%)
    apk (aggressive)504 kB504 kB+88 B (+0.0%)
    apk (release)1.22 MB1.22 MB-24 B (-0.0%)

Test Logs

Notes

  • Commit (ef9134e) is created by Prow via merging PR base commit (63efd46) and head commit (6d22c53).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MEfPPVkhsn.html

@gsakakihara gsakakihara merged commit 56b0cd3 into master Mar 18, 2022
@gsakakihara gsakakihara deleted the gsakakihara/catch_bundle_exceptions branch March 18, 2022 20:59
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
@gsakakihara @jeremyjiang-dev
Catch RuntimeException when getting analytics Bundle. (#3564)
45ce309 
#3538
* Added catching RuntimeException when trying to get the analytics data Bundle from the Activity Intent since it's possible that the extras could contain invalid or incorrectly formatted data that will throw an Exception when trying to get the Bundle.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@gsakakihara @jeremyjiang-dev
Catch RuntimeException when getting analytics Bundle. (#3564)
445cca2 
#3538
* Added catching RuntimeException when trying to get the analytics data Bundle from the Activity Intent since it's possible that the extras could contain invalid or incorrectly formatted data that will throw an Exception when trying to get the Bundle.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@gsakakihara @jeremyjiang-dev
Catch RuntimeException when getting analytics Bundle. (#3564)
eab00d4 
#3538
* Added catching RuntimeException when trying to get the analytics data Bundle from the Activity Intent since it's possible that the extras could contain invalid or incorrectly formatted data that will throw an Exception when trying to get the Bundle.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@gsakakihara @jeremyjiang-dev
Catch RuntimeException when getting analytics Bundle. (#3564)
ba3c99a 
#3538
* Added catching RuntimeException when trying to get the analytics data Bundle from the Activity Intent since it's possible that the extras could contain invalid or incorrectly formatted data that will throw an Exception when trying to get the Bundle.
@firebase firebase locked and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willxu-google willxu-google willxu-google approved these changes

@welishr welishr Awaiting requested review from welishr

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsakakihara @google-oss-bot @willxu-google