Skip to content

Use assertThrows() in StorageReferenceTest #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

kluever
Copy link
Contributor

@kluever kluever commented Mar 21, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

Hi @kluever. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlazo
Copy link
Collaborator

rlazo commented Mar 21, 2022

/ok-to-test

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (56b0cd3) and merge commit (ef8260d).

Test Logs

Notes

  • Commit (ef8260d) is created by Prow via merging PR base commit (56b0cd3) and head commit (b5e0810).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dZogGheNu1.html

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@kluever: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests b5e0810 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit e1fcfc3 into firebase:master Mar 21, 2022
@firebase firebase locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants