Skip to content

Simplify segment count calculation #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.29% (6e788ac) to 46.11% (373ddde) by -0.18%.

    FilenameBase (6e788ac)Merge (373ddde)Diff
    AsyncQueue.java78.61%78.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    DeleteMutation.java90.48%95.24%+4.76%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.52%31.11%-7.41%
    GrpcCallProvider.java69.41%62.35%-7.06%
    IndexBackfiller.java92.19%76.56%-15.63%
    LruGarbageCollector.java93.46%84.11%-9.35%
    SQLiteIndexManager.java99.49%99.48%-0.01%

Test Logs

Notes

  • Commit (373ddde) is created by Prow via merging PR base commit (6e788ac) and head commit (9d4a002).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jJOQHpS1aS.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (6e788ac)Merge (373ddde)Diff
    aar1.25 MB1.25 MB-315 B (-0.0%)
    apk (release)3.38 MB3.38 MB+44 B (+0.0%)

Test Logs

Notes

  • Commit (373ddde) is created by Prow via merging PR base commit (6e788ac) and head commit (9d4a002).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MY3LKmwaR9.html

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 9d4a002 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit 148cc77 into master Apr 13, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/segmentcount branch April 13, 2022 17:24
@firebase firebase locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants