QueryEngine clean up

[schmidt-sebastian]

No description provided.

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-firestore

  Overall coverage changed from 46.26% (5f7ac45) to 46.10% (0140abc) by -0.16%.

  Filename	Base (5f7ac45)	Merge (0140abc)	Diff
  AsyncQueue.java	78.61%	78.11%	-0.50%
  Datastore.java	32.14%	29.76%	-2.38%
  FirestoreChannel.java	18.10%	16.38%	-1.72%
  FirestoreClient.java	38.52%	31.11%	-7.41%
  GrpcCallProvider.java	69.41%	62.35%	-7.06%
  IndexBackfiller.java	92.19%	76.56%	-15.63%
  LruGarbageCollector.java	93.46%	84.11%	-9.35%
  SetMutation.java	94.44%	97.22%	+2.78%

Test Logs

• Base (5f7ac45): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1514300845032738819
• Merge (0140abc): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3646/check-coverage-changed/1514344129629261828

Notes

• Commit (0140abc) is created by Prow via merging PR base commit (5f7ac45) and head commit (34a19ec).
• Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

1. https://storage.googleapis.com/firebase-sdk-metric-reports/7l1yseigCh.html

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-firestore

  Type	Base (5f7ac45)	Merge (0140abc)	Diff
  aar	1.25 MB	1.25 MB	-29 B (-0.0%)
  apk (release)	3.38 MB	3.38 MB	+40 B (+0.0%)

Test Logs

• Base (5f7ac45): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1514300845032738817
• Merge (0140abc): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3646/binary-size/1514344129629261827

Notes

• Commit (0140abc) is created by Prow via merging PR base commit (5f7ac45) and head commit (34a19ec).

1. https://storage.googleapis.com/firebase-sdk-metric-reports/q1P0jrFe8x.html

[google-oss-bot]

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
smoke-tests	34a19ec	link	/test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.