Skip to content

Move getIndexType() test #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Move getIndexType() test #3650

merged 1 commit into from
Apr 14, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

The test should be in SQLiteIndexManagerTest as it only tests logic in getIndexType()

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.09% (11dc9e9) to 46.10% (44cd8df) by +0.00%.

    FilenameBase (11dc9e9)Merge (44cd8df)Diff
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

Notes

  • Commit (44cd8df) is created by Prow via merging PR base commit (11dc9e9) and head commit (7b418e1).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oqIsAdhRgd.html

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 7b418e1 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit 5600426 into master Apr 14, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/movetests branch April 14, 2022 16:55
@firebase firebase locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants