Skip to content

Avoid using wildcards in imports. #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2022
Merged

Avoid using wildcards in imports. #3675

merged 3 commits into from
Apr 25, 2022

Conversation

visumickey
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 23, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from 71.39% (d8ec3fb) to 71.38% (0f52175) by -0.02%.

    FilenameBase (d8ec3fb)Merge (0f52175)Diff
    RateLimiter.java91.73%90.98%-0.75%

Test Logs

Notes

  • Commit (0f52175) is created by Prow via merging PR base commit (d8ec3fb) and head commit (ae6554a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Zj90unOXbH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 23, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (d8ec3fb)Merge (0f52175)Diff
    aar308 kB308 kB-1 B (-0.0%)
    apk (release)2.47 MB2.47 MB+48 B (+0.0%)

Test Logs

Notes

  • Commit (0f52175) is created by Prow via merging PR base commit (d8ec3fb) and head commit (ae6554a).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4pxlROgyRC.html

jposuna
jposuna approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@jposuna jposuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a quick search on the codebase and replace the rest? I remember seeing others in the previous PR (e.g. https://github.com/firebase/firebase-android-sdk/pull/3660/files#diff-62b12463b558f4742e85a37fb537c3a27ecea13241cc4799c392f33517ecec9a)

@visumickey
Copy link
Contributor Author

Can you do a quick search on the codebase and replace the rest? I remember seeing others in the previous PR (e.g. https://github.com/firebase/firebase-android-sdk/pull/3660/files#diff-62b12463b558f4742e85a37fb537c3a27ecea13241cc4799c392f33517ecec9a)

Good point. Updated the references in all parts of the code to avoid wildcard inclusions for imports.

@visumickey
Copy link
Contributor Author

/retest

@visumickey visumickey merged commit b600e83 into master Apr 25, 2022
@visumickey visumickey deleted the perfFixStaticImport branch April 25, 2022 20:34
@firebase firebase locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jposuna jposuna jposuna approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

@leotianlizhan leotianlizhan Awaiting requested review from leotianlizhan

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @jposuna @jeremyjiang-dev